Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fl.Short() call in adaptflag to reflect breaking upstream API change #4

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

q3k
Copy link
Contributor

@q3k q3k commented Apr 17, 2017

Over in kingpin commit ea545afe29292738d692fa467690a9a34f61deaa the flag.Short() method was changed to accept runes instead of bytes. This change removes the manual cast from adaptflag.

Without this change neither easyconfig nor any of its' dependees cannot build, as the kingpin library changed this without an API version bump.

@hlandau hlandau merged commit 7589cb9 into hlandau:master Apr 17, 2017
@hlandau
Copy link
Owner

hlandau commented Apr 17, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants